Skip to content

Update PULL_REQUEST_TEMPLATE.md#29621

Merged
goderbauer merged 1 commit intomasterfrom
Hixie-patch-1
Mar 29, 2019
Merged

Update PULL_REQUEST_TEMPLATE.md#29621
goderbauer merged 1 commit intomasterfrom
Hixie-patch-1

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Mar 19, 2019

This tries to make it more obvious when someone checks the "tests" box without actually having added tests.

This tries to make it more obvious when someone checks the "tests" box without actually having added tests.
@Hixie Hixie requested a review from goderbauer March 19, 2019 19:26
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@goderbauer goderbauer added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 19, 2019
@goderbauer goderbauer merged commit 1123b71 into master Mar 29, 2019
@dnfield dnfield deleted the Hixie-patch-1 branch May 15, 2019 16:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants