Skip to content

Linking Higher & Lower Class Docs#29758

Merged
Piinks merged 2 commits intoflutter:masterfrom
Piinks:layerLinking
Mar 26, 2019
Merged

Linking Higher & Lower Class Docs#29758
Piinks merged 2 commits intoflutter:masterfrom
Piinks:layerLinking

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 21, 2019

Description

This PR links higher layer classes to their corresponding lower layer classes in dart:ui.
Links for lower-->higher in flutter/engine: #8265 (already merged).

Related Issues

#22859

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ labels Mar 21, 2019
@Piinks Piinks changed the title WIP Linking Higher & Lower Class Docs Linking Higher & Lower Class Docs Mar 22, 2019
@Piinks Piinks changed the title Linking Higher & Lower Class Docs WIP Linking Higher & Lower Class Docs Mar 25, 2019
@Piinks Piinks changed the title WIP Linking Higher & Lower Class Docs Linking Higher & Lower Class Docs Mar 25, 2019
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks merged commit 204ecee into flutter:master Mar 26, 2019
@Piinks Piinks deleted the layerLinking branch November 22, 2019 00:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants