Skip to content

Directly depend on frontend_server tool in fuchsia_attach#29768

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:add_frontend_server_dep
Mar 27, 2019
Merged

Directly depend on frontend_server tool in fuchsia_attach#29768
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:add_frontend_server_dep

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 21, 2019

Description

This prevents the frontend_server from not being built due to configurations changing in fuchsia.

Related Issues

#29762

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@jonahwilliams jonahwilliams added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 21, 2019
@jonahwilliams jonahwilliams requested a review from mklim March 22, 2019 01:21
@jonahwilliams jonahwilliams requested a review from zanderso March 25, 2019 16:50
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit 141f87b into flutter:master Mar 27, 2019
@jonahwilliams jonahwilliams deleted the add_frontend_server_dep branch March 27, 2019 00:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants