Watch wildcard directories in addition to asset bundle#29883
Merged
jonahwilliams merged 4 commits intoflutter:masterfrom Mar 27, 2019
Merged
Watch wildcard directories in addition to asset bundle#29883jonahwilliams merged 4 commits intoflutter:masterfrom
jonahwilliams merged 4 commits intoflutter:masterfrom
Conversation
Add documentation describing which assets are expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently we only update assets when we detect either a change to an existing asset or an update to the asset manifest. Due to the existence of wildcard assets
foo/(all files directly under foo), it is possible for a user to add a new asset which isn't detected through either of these previous approaches.To fix this, we can track each wildcard directory in addition to the asset manifest, and mark the bundle as needing to be updated when the directory stat has occurred after the last build time. This allows adding a new asset to a wildcard directory and hot reloading it.
Related Issues
Fixes #18896
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?