Skip to content

ensure packages file is updated when using build_runner#29885

Merged
jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams:update_packages_file
Mar 27, 2019
Merged

ensure packages file is updated when using build_runner#29885
jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams:update_packages_file

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 24, 2019 •
edited
Loading

Description

If the generate packages file is updated, ensure we detect changes and update it accordingly.

Related Issues

Fixes #29884

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 25, 2019
@jonahwilliams jonahwilliams requested a review from yjbanov March 27, 2019 17:35
@jonahwilliams jonahwilliams marked this pull request as ready for review March 27, 2019 17:35
yjbanov
yjbanov approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams jonahwilliams merged commit 50f1e18 into flutter:master Mar 27, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure generated packages is updated when using build_runner

4 participants

@jonahwilliams @yjbanov @goderbauer @googlebot