ValueNotifier changed to use identical() rather than operator==#29926
Closed
ravenblackx wants to merge 1 commit intoflutter:masterfrom
ravenblackx:fix/29922
Closed
ValueNotifier changed to use identical() rather than operator==#29926ravenblackx wants to merge 1 commit intoflutter:masterfrom ravenblackx:fix/29922
ravenblackx wants to merge 1 commit intoflutter:masterfrom
ravenblackx:fix/29922
Conversation
HansMuller
reviewed
Mar 27, 2019
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
Thanks for contributing a fix! In this case changing the meaning of ValueNotifier wouldn't be a backwards compatible change. The ValueNotifier API doc should really explain that the listeners are notified when the new value is not == to the old value; currently it just says that notifications happen when the value is "replaced".
If you'd be willing to change this PR into a doc change, I can help land it.
Thanks!
9 tasks
Member
|
Created #30461 to make the docs more specific on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed ValueNotifier to use identical() rather than operator== to determine whether to notify listeners of a change.
Related Issues
#29922
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?