Skip to content

Limit the semantic nodes ID range to 2^16#29928

Merged
amirh merged 1 commit intoflutter:masterfrom
amirh:semantic_node_range
Mar 26, 2019
Merged

Limit the semantic nodes ID range to 2^16#29928
amirh merged 1 commit intoflutter:masterfrom
amirh:semantic_node_range

Conversation

@amirh
Copy link
Contributor

@amirh amirh commented Mar 25, 2019

Description

This PR limits the framework generated semantic node IDs to be smaller than 2^16, this allows to safely generate semantic node in the engine with IDs >= 2^16 avoiding ID collision (which is done in flutter/engine#8250).

Related Issues

#19418

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See [Test Coverage]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]).
  • No, this is not a breaking change.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label Mar 25, 2019
@amirh amirh merged commit f652f01 into flutter:master Mar 26, 2019
@amirh amirh deleted the semantic_node_range branch March 26, 2019 16:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants