Pass FLUTTER_TOOL_ARGS to snapshot command.#29938
Merged
jonahwilliams merged 12 commits intoflutter:masterfrom Mar 27, 2019
Merged
Pass FLUTTER_TOOL_ARGS to snapshot command.#29938jonahwilliams merged 12 commits intoflutter:masterfrom
jonahwilliams merged 12 commits intoflutter:masterfrom
Conversation
goderbauer
added
the
tool
Contributor
Author
|
cc @Hixie |
goderbauer
approved these changes
Mar 27, 2019
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
Does this make running these tests (a lot) slower?
bin/flutter.bat
Outdated
| POPD | ||
|
|
||
| "%dart%" --snapshot="%snapshot_path%" --snapshot-kind=app-jit --packages="%flutter_tools_dir%\.packages" "%script_path%" | ||
| IF "%FLUTTER_TOOL_ARGS%"=="" ( |
Member
There was a problem hiding this comment.
nit: spaces arround == if batch allows it.
Contributor
Author
|
Yes :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure that we can run app-jit snapshot flutter tool with asserts
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?