Remove unwanted gap between navigation bar and safe area's child#29943
Merged
LongCatIsLooong merged 7 commits intoflutter:masterfrom Mar 27, 2019
Merged
Conversation
xster
reviewed
Mar 25, 2019
0146c0a to
839e78a
Compare
1e5c98c to
4351f8d
Compare
4351f8d to
cc7af42
Compare
xster
reviewed
Mar 26, 2019
xster
approved these changes
Mar 26, 2019
Member
xster
left a comment
There was a problem hiding this comment.
Looks good. Just some small comments to address.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the additional top padding from
CupertinoPageScaffold'sMediaQuerywhen the navigation bar is opaque (as the padding was already consumed by the navigation bar).Related Issues
#29136
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?