Skip to content

Remove unwanted gap between navigation bar and safe area's child#29943

Merged
LongCatIsLooong merged 7 commits intoflutter:masterfrom
LongCatIsLooong:removeUnwantedGapBetweenNavBarAndSafeAreaChild
Mar 27, 2019
Merged

Remove unwanted gap between navigation bar and safe area's child#29943
LongCatIsLooong merged 7 commits intoflutter:masterfrom
LongCatIsLooong:removeUnwantedGapBetweenNavBarAndSafeAreaChild

Conversation

@LongCatIsLooong
Copy link
Contributor

Description

Remove the additional top padding from CupertinoPageScaffold's MediaQuery when the navigation bar is opaque (as the padding was already consumed by the navigation bar).

Related Issues

#29136

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@LongCatIsLooong LongCatIsLooong force-pushed the removeUnwantedGapBetweenNavBarAndSafeAreaChild branch from 0146c0a to 839e78a Compare March 25, 2019 23:39
@goderbauer goderbauer added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Mar 25, 2019
@LongCatIsLooong LongCatIsLooong force-pushed the removeUnwantedGapBetweenNavBarAndSafeAreaChild branch from 1e5c98c to 4351f8d Compare March 26, 2019 00:14
@LongCatIsLooong LongCatIsLooong force-pushed the removeUnwantedGapBetweenNavBarAndSafeAreaChild branch from 4351f8d to cc7af42 Compare March 26, 2019 00:16
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review March 26, 2019 00:17
@LongCatIsLooong LongCatIsLooong requested a review from xster March 26, 2019 00:17
@LongCatIsLooong LongCatIsLooong requested a review from xster March 26, 2019 17:08
Copy link
Member

@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some small comments to address.

@xster
Copy link
Member

xster commented Mar 26, 2019

LGTM

@LongCatIsLooong LongCatIsLooong merged commit 673e989 into flutter:master Mar 27, 2019
@LongCatIsLooong LongCatIsLooong deleted the removeUnwantedGapBetweenNavBarAndSafeAreaChild branch March 27, 2019 16:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants