Fix issue with account drawer header arrow rotating when setState is called#29980
Merged
rami-a merged 5 commits intoflutter:masterfrom Mar 27, 2019
Merged
Fix issue with account drawer header arrow rotating when setState is called#29980rami-a merged 5 commits intoflutter:masterfrom
rami-a merged 5 commits intoflutter:masterfrom
Conversation
Piinks
added
the
f: material design
johnsonmh
reviewed
Mar 26, 2019
packages/flutter/test/material/user_accounts_drawer_header_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter/test/material/user_accounts_drawer_header_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter/test/material/user_accounts_drawer_header_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter/test/material/user_accounts_drawer_header_test.dart
Outdated
Show resolved
Hide resolved
added 2 commits
March 26, 2019 15:23
HansMuller
approved these changes
Mar 27, 2019
| if (_animation.status == AnimationStatus.dismissed || | ||
| _animation.status == AnimationStatus.reverse) { | ||
| // If the state of the arrow did not change, there is no need to trigger the animation | ||
| if (oldWidget.isOpen == widget.isOpen) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The UserAccountsDrawerHeader had a bug with the arrow rotating whenever setState was called on its parent. This change makes sure that we check that the state actually changed before allowing the animation to trigger.
Related Issues
Fixes #25801
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?