Skip to content

Lazy cache 5: The Empire Strikes Back#29986

Merged
jonahwilliams merged 16 commits intoflutter:masterfrom
jonahwilliams:lazy_cache_4
Mar 27, 2019
Merged

Lazy cache 5: The Empire Strikes Back#29986
jonahwilliams merged 16 commits intoflutter:masterfrom
jonahwilliams:lazy_cache_4

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 26, 2019

Description

Fix from last time: ensure that each separate artifact has a distinct stamp file, otherwise the order in which artifacts are downloaded will break us.


Attempts to make artifact down-loading lazy. Classifies each CachedArtifact as being either universal or supporting a specific platform. Refactors the EngineArtifact class into a universal, android, or iOS category.

Each command must identify which artifacts it requires statically. Currently all commands required universal, android, and iOS. The web sdk is now only downloaded when running flutter build web

flutter precache now accepts additional flags to force downloading of the artifacts, the defaults include android, ios, and universal.

To improve downloading further, we need to identify which artifacts are required in the build commands
based on the target platform.

Related Issues

Work towards #6491

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@jonahwilliams jonahwilliams changed the title Lazy cache ~4~ 5 Lazy cache 5 Mar 26, 2019
@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 26, 2019
@jonahwilliams jonahwilliams marked this pull request as ready for review March 27, 2019 01:02
@jonahwilliams jonahwilliams changed the title Lazy cache 5 Lazy cache 5: The Empire Strikes Back Mar 27, 2019
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Rocky-XXXVIII_zps5f91145d

@jonahwilliams jonahwilliams merged commit 7d678f2 into flutter:master Mar 27, 2019
@jonahwilliams jonahwilliams deleted the lazy_cache_4 branch March 27, 2019 21:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants