Lazy cache 5: The Empire Strikes Back#29986
Merged
jonahwilliams merged 16 commits intoflutter:masterfrom Mar 27, 2019
Merged
Conversation
added 11 commits
March 21, 2019 22:02
added 2 commits
March 26, 2019 16:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Fix from last time: ensure that each separate artifact has a distinct stamp file, otherwise the order in which artifacts are downloaded will break us.
Attempts to make artifact down-loading lazy. Classifies each CachedArtifact as being either universal or supporting a specific platform. Refactors the EngineArtifact class into a universal, android, or iOS category.
Each command must identify which artifacts it requires statically. Currently all commands required universal, android, and iOS. The web sdk is now only downloaded when running flutter build web
flutter precache now accepts additional flags to force downloading of the artifacts, the defaults include android, ios, and universal.
To improve downloading further, we need to identify which artifacts are required in the build commands
based on the target platform.
Related Issues
Work towards #6491
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?