Skip to content

Avoid overwriting task result for non-leak checkers#29989

Merged
dnfield merged 1 commit intoflutter:masterfrom
dnfield:fix_leaky_check
Mar 26, 2019
Merged

Avoid overwriting task result for non-leak checkers#29989
dnfield merged 1 commit intoflutter:masterfrom
dnfield:fix_leaky_check

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Mar 26, 2019

Description

After checking for leaking processes landed in the devicelab, we were inadvertently failing to send benchmark results for tasks that leaked a process.

Related Issues

#29196

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@dnfield dnfield requested a review from jonahwilliams March 26, 2019 18:29
@dnfield dnfield added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 26, 2019
@jonahwilliams
Copy link
Contributor

LGTM

@dnfield dnfield merged commit 820b0e0 into flutter:master Mar 26, 2019
@dnfield dnfield deleted the fix_leaky_check branch March 26, 2019 18:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants