Skip to content

Update to latest matcher#30019

Merged
jonahwilliams merged 8 commits intoflutter:masterfrom
jonahwilliams:fix_matcher_cases
Mar 28, 2019
Merged

Update to latest matcher#30019
jonahwilliams merged 8 commits intoflutter:masterfrom
jonahwilliams:fix_matcher_cases

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 27, 2019

Description

Roll dependencies to include latest test and matcher. Update failing test cases that were using buggy logic to pass with greaterThan instead of greaterThanOrEqualTo in the case of sizes and offsets.

cc @natebosch

Related Issues

Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@jonahwilliams jonahwilliams marked this pull request as ready for review March 27, 2019 05:50
@jonahwilliams jonahwilliams requested a review from dnfield March 27, 2019 17:41
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 27, 2019
@jonahwilliams jonahwilliams merged commit 3c93b65 into flutter:master Mar 28, 2019
@jonahwilliams jonahwilliams deleted the fix_matcher_cases branch March 28, 2019 00:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants