Skip to content

Document that Hero needs to be present on destination page's zero frame#30048

Merged
shihaohong merged 1 commit intoflutter:masterfrom
shihaohong:heroes-doc-update
Mar 28, 2019
Merged

Document that Hero needs to be present on destination page's zero frame#30048
shihaohong merged 1 commit intoflutter:masterfrom
shihaohong:heroes-doc-update

Conversation

@shihaohong
Copy link
Contributor

Description

Adds a line letting users know that they need to have the Hero present on the very first frame of the destination route for the animation to trigger.

Related Issues

Fixes #15586

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@shihaohong shihaohong requested a review from HansMuller March 27, 2019 16:54
@shihaohong shihaohong changed the title Document Hero needs to be present on destination page's zero frame Document that Hero needs to be present on destination page's zero frame Mar 27, 2019
@shihaohong shihaohong added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. labels Mar 27, 2019
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shihaohong shihaohong merged commit de6995c into flutter:master Mar 28, 2019
@shihaohong shihaohong deleted the heroes-doc-update branch March 28, 2019 01:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document that Hero needs everything present and ready on frame zero of the transition animation

3 participants