Skip to content

Change -c to --enable-asserts#30055

Merged
liyuqian merged 1 commit intoflutter:masterfrom
liyuqian:windows_flag
Mar 27, 2019
Merged

Change -c to --enable-asserts#30055
liyuqian merged 1 commit intoflutter:masterfrom
liyuqian:windows_flag

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Mar 27, 2019

Unblock the engine roll that includes the Dart roll that removes -c.

See, e.g., #29956

Unblock the engine roll that includes the Dart roll that removes `-c`.
@liyuqian liyuqian requested review from DanTup and gspencergoog March 27, 2019 18:10
@liyuqian liyuqian changed the title Change -c to --enable-asserts Change -c to --enable-asserts Mar 27, 2019
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm_hanko

@liyuqian
Copy link
Contributor Author

Merge as one windows bot has passed to unblock the engine roll ASAP as we have .

@liyuqian liyuqian merged commit 0b68712 into flutter:master Mar 27, 2019
@liyuqian liyuqian deleted the windows_flag branch March 27, 2019 23:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants