Text inline widgets, TextSpan rework#30069
Closed
GaryQian wants to merge 101 commits intoflutter:masterfrom
Closed
Text inline widgets, TextSpan rework#30069GaryQian wants to merge 101 commits intoflutter:masterfrom
GaryQian wants to merge 101 commits intoflutter:masterfrom
Conversation
GaryQian
added
a: text input
Contributor
|
@GaryQian lets make that widgets placed as inline text widgets can also contribute semantics |
Contributor
Author
|
Have checked that semantics are being correctly built up and passed through, although I will verify with some people who are more familiar with semantics if it is indeed the full behavior |
goderbauer
added
the
framework
skreborn
reviewed
Apr 1, 2019
goderbauer
reviewed
May 30, 2019
goderbauer
reviewed
May 31, 2019
goderbauer
reviewed
May 31, 2019
goderbauer
reviewed
May 31, 2019
goderbauer
reviewed
May 31, 2019
goderbauer
approved these changes
May 31, 2019
| @@ -415,11 +415,8 @@ class RenderParagraph extends RenderBox | |||
| assert(() { | |||
| final Offset manualPosition = (position - textParentData.offset) / textParentData.scale; | |||
| // Compare the two offsets ignoring floating point error. | |||
Member
There was a problem hiding this comment.
nit: remove this comment? It's rather obvious what's happening below, I think.
Contributor
Author
|
Due to versioning calculation, #33794 squashes this PR on top of master. Further changes can be seen there. |
Contributor
Author
|
Closing this, will be landing the other version. |
This was referenced Jun 5, 2019
GaryQian
added a commit
that referenced
this pull request
Jun 7, 2019
…backwards compatibility (#34051)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the capability of embedding widgets inline into paragraphs.
New TextSpan inheritance structure is the following:
Wrap widgets to embed in
WidgetSpan(widget: <yourwidgethere>)The TextSpan changes make this a breaking change, although existing code passing
<TextSpan>[]intoRichTextorTextPaintershould still work as expected. Only code directly modifying a InlineSpan tree will be affected.Fix/Addition for #2022
Dependent on the engine/LibTxt side PR: flutter/engine#8207
Work continued in #33946