Move spinner _defaultSlowWarning message to a new line#30071
Merged
christopherfujino merged 8 commits intoflutter:masterfrom Mar 28, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In an
AnsiSpinner(whichStdoutLoggerinstantiates if terminal supports ANSI), there is a_defaultSlowWarningwhich shows after thetimeoutduration. The below issue points out that this warning message prints after the spinner, which makes the message difficult to read. This fix clears the spinner animation, and breaks to a newline before printing the warning message the first time. On successive iterations, the spinner is animated after the message.Old
New
Related Issues
Resolves Flutter CLi Error on hot reload and hot restart #29598.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?