Skip to content

Move spinner _defaultSlowWarning message to a new line#30071

Merged
christopherfujino merged 8 commits intoflutter:masterfrom
chris-forks:move-slow-restart-warning-to-new-line
Mar 28, 2019
Merged

Move spinner _defaultSlowWarning message to a new line#30071
christopherfujino merged 8 commits intoflutter:masterfrom
chris-forks:move-slow-restart-warning-to-new-line

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Mar 27, 2019

Description

In an AnsiSpinner (which StdoutLogger instantiates if terminal supports ANSI), there is a _defaultSlowWarning which shows after the timeout duration. The below issue points out that this warning message prints after the spinner, which makes the message difficult to read. This fix clears the spinner animation, and breaks to a newline before printing the warning message the first time. On successive iterations, the spinner is animated after the message.

Old

old-hot-restart

New

hot-restart-screenshot

Related Issues

Resolves Flutter CLi Error on hot reload and hot restart #29598.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See [Test Coverage]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]).
  • No, this is not a breaking change.

@christopherfujino christopherfujino added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 27, 2019
@jonahwilliams jonahwilliams self-requested a review March 28, 2019 17:04
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino merged commit ec93c87 into flutter:master Mar 28, 2019
@christopherfujino christopherfujino deleted the move-slow-restart-warning-to-new-line branch April 16, 2019 15:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter CLi Error on hot reload and hot restart

3 participants