Adds FocusHighlight widget to show highlights around focused widgets.#30077
Closed
gspencergoog wants to merge 2 commits intoflutter:masterfrom
Closed
Adds FocusHighlight widget to show highlights around focused widgets.#30077gspencergoog wants to merge 2 commits intoflutter:masterfrom
gspencergoog wants to merge 2 commits intoflutter:masterfrom
Conversation
gspencergoog
changed the title
9 tasks
gspencergoog
force-pushed
the
focus_addons
branch
7 times, most recently
from
e54eae6 to
e933b67
Compare
goderbauer
added
framework
gspencergoog
force-pushed
the
focus_addons
branch
9 times, most recently
from
3fd9bf5 to
6bdb4d4
Compare
Hixie
reviewed
Apr 3, 2019
Hixie
reviewed
Apr 3, 2019
Hixie
reviewed
Apr 3, 2019
Hixie
reviewed
Apr 3, 2019
Hixie
reviewed
Apr 3, 2019
Hixie
reviewed
Apr 3, 2019
Hixie
reviewed
Apr 3, 2019
Hixie
reviewed
Apr 3, 2019
Hixie
reviewed
Apr 3, 2019
gspencergoog
force-pushed
the
focus_addons
branch
12 times, most recently
from
4b0e050 to
cef7428
Compare
gspencergoog
force-pushed
the
focus_addons
branch
14 times, most recently
from
8fd4823 to
9127e86
Compare
Hixie
reviewed
May 11, 2019
Contributor
There was a problem hiding this comment.
please use the pattern in the style guide
Contributor
Author
|
Closing this, since I decided that the I'll move some of the minor cleanups that were here into another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implements a
FocusHighlightwidget to do highlighting of focused widgets, in addition to some examples and manual tests for focus.It also currently includes the contents of #30076, which will be rebased out after that is committed.
Here is a diff of the two so it's obvious what is included here.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?