Fix refresh control in the gallery demo, update comments #30129
Merged
LongCatIsLooong merged 21 commits intoflutter:masterfrom Apr 26, 2019
Merged
Fix refresh control in the gallery demo, update comments #30129LongCatIsLooong merged 21 commits intoflutter:masterfrom
LongCatIsLooong merged 21 commits intoflutter:masterfrom
Conversation
9 tasks
xster
reviewed
Mar 29, 2019
examples/flutter_gallery/lib/demo/cupertino/cupertino_refresh_demo.dart
Outdated
Show resolved
Hide resolved
examples/flutter_gallery/lib/demo/cupertino/cupertino_refresh_demo.dart
Outdated
Show resolved
Hide resolved
goderbauer
added
framework
LongCatIsLooong
force-pushed
the
updateCupertinoSliverRefControlDoc
branch
from
0d1b366 to
bd07e2c
Compare
LongCatIsLooong
force-pushed
the
updateCupertinoSliverRefControlDoc
branch
from
bd07e2c to
dff5bf2
Compare
LongCatIsLooong
force-pushed
the
updateCupertinoSliverRefControlDoc
branch
2 times, most recently
from
9a46db2 to
477359e
Compare
LongCatIsLooong
force-pushed
the
updateCupertinoSliverRefControlDoc
branch
from
477359e to
0348308
Compare
Contributor
Author
|
@xster the workaround seems to be working. |
Member
|
Is this ready for review? |
Contributor
Author
yep |
xster
reviewed
Apr 23, 2019
Member
xster
left a comment
xster
left a comment
There was a problem hiding this comment.
Sorry I started reviewing but forgot to press submit
examples/flutter_gallery/lib/demo/cupertino/cupertino_refresh_demo.dart
Outdated
Show resolved
Hide resolved
examples/flutter_gallery/lib/demo/cupertino/cupertino_refresh_demo.dart
Outdated
Show resolved
Hide resolved
Member
|
LGTM |
This was referenced May 13, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CupertinoRefreshControldoesn't work in the gallery demo on Android.CupertinoRefreshControlScrollPhysicsRelated Issues
Fixes #21820
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?