Skip to content

disable jit snapshot#30204

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:switch_back_to_kernel
Mar 29, 2019
Merged

disable jit snapshot#30204
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:switch_back_to_kernel

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 29, 2019

Description

There is a potential regression in snapshotting that we are not testing. Revert the jit snapshot.

Related Issues

#30203

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@amirh
Copy link
Contributor

amirh commented Mar 29, 2019

RSLGTM assuming this is a rollback of the recent: #27749

@jonahwilliams jonahwilliams merged commit d4f8a7f into flutter:master Mar 29, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants