Skip to content

Add 29 Widget of the Week videos#30415

Merged
goderbauer merged 2 commits intoflutter:masterfrom
goderbauer:youtube
Apr 3, 2019
Merged

Add 29 Widget of the Week videos#30415
goderbauer merged 2 commits intoflutter:masterfrom
goderbauer:youtube

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Apr 3, 2019 •
edited
Loading

Description

Embeds all 29 existing widget of the week videos from this playlist (plus the video for Positioned, which is missing on the playlist) into our dartdocs.

This is what it looks like:
Screen Shot 2019-04-03 at 9 50 54 AM

This will require the dartdoc bump from #30451.

Related Issues

None

Tests

I added the following tests:

None.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@goderbauer goderbauer changed the title [WIP] Add 28 Widget of the Week videos [WIP] Add 29 Widget of the Week videos Apr 3, 2019
@goderbauer goderbauer changed the title [WIP] Add 29 Widget of the Week videos Add 29 Widget of the Week videos Apr 3, 2019
@goderbauer goderbauer marked this pull request as ready for review April 3, 2019 16:57
gspencergoog
gspencergoog approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@sfshaza2
Copy link
Contributor

sfshaza2 commented Apr 3, 2019

WOOT! This is amazing!

One question, though. What about also adding the videos for:

Using Material Design with Flutter to the material lib: https://www.youtube.com/watch?v=DL0Ix1lnC4w&list=PLjxrf2q8roU2HdJQDjJzOeO6J3FoFLWr2&index=3

How to create Stateful Widgets to StatelessWidget: https://www.youtube.com/watch?v=wE7khGHVkYY&list=PLjxrf2q8roU2HdJQDjJzOeO6J3FoFLWr2&index=5

How Stateful widgets are used best to StatefulWidget: https://www.youtube.com/watch?v=AqCMFXEmf3w&list=PLjxrf2q8roU2HdJQDjJzOeO6J3FoFLWr2&index=6

InheritedWidgets explained to InheritedWidget: https://www.youtube.com/watch?v=Zbm3hjPjQMk&list=PLjxrf2q8roU2HdJQDjJzOeO6J3FoFLWr2&index=7

When to use Keys to Keys: https://www.youtube.com/watch?v=kn0EOS-ZiIc&list=PLjxrf2q8roU2HdJQDjJzOeO6J3FoFLWr2&index=8

Flutters Cupertino Package for iOS devs to the cupertino library: https://www.youtube.com/watch?v=3PdUaidHc-E&list=PLjxrf2q8roU2HdJQDjJzOeO6J3FoFLWr2&index=10

Here's the whole Flutter in Focus playlist: https://www.youtube.com/playlist?list=PLjxrf2q8roU2HdJQDjJzOeO6J3FoFLWr2

Otherwise, LGTM!

@goderbauer
Copy link
Member Author

goderbauer commented Apr 3, 2019

@sfshaza2 Great idea, I'll add them in a follow-up PR. Also, feel free to send PRs to add more videos to the appropriate places! 😄

@goderbauer goderbauer mentioned this pull request Apr 3, 2019
Merged
9 tasks
@redbrogdon
Copy link
Contributor

redbrogdon commented Apr 3, 2019

Thanks for doing this!

DevRel will need to make a point of adding new Widgets of the Week as they're released.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ labels Apr 3, 2019
@goderbauer
Copy link
Member Author

goderbauer commented Apr 3, 2019

The lucy build is actually green.

@goderbauer goderbauer merged commit 516ffd0 into flutter:master Apr 3, 2019
@goderbauer goderbauer deleted the youtube branch April 3, 2019 19:48
@Piinks Piinks mentioned this pull request Apr 3, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@sfshaza2 sfshaza2 Awaiting requested review from sfshaza2

@redbrogdon redbrogdon Awaiting requested review from redbrogdon

Assignees

No one assigned

Labels

d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@goderbauer @sfshaza2 @redbrogdon @gspencergoog @googlebot @Piinks