Fix return type of _createErrorWidget in sliver.dart#30431
Closed
ymback wants to merge 1 commit intoflutter:masterfrom
Closed
Fix return type of _createErrorWidget in sliver.dart#30431ymback wants to merge 1 commit intoflutter:masterfrom
ymback wants to merge 1 commit intoflutter:masterfrom
Conversation
If we use `ErrorWidget.builder` to set a custom error widget, the `_createErrorWidget` function in **sliver.dart** will throw >Another exception was thrown: type 'AnzongErrorWidget' is not a subtype of type 'ErrorWidget' because `_createErrorWidget` needs to return `ErrorWidget`, which now is `Widget`, maybe `Center` or any other widgets, and this leads to an empty view instand of our custom error widget.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Piinks
added
the
framework
Member
|
Good catch. Thanks for the contribution. In order for us to accept the PR, you will have to add a test to ensure that we never break this again. Can you please do that? |
goderbauer
changed the title
Piinks
added
the
waiting for customer response
Member
|
@dnfield volunteered to add a test. |
dnfield
added a commit
to dnfield/flutter
that referenced
this pull request
Apr 10, 2019
9 tasks
Contributor
|
Continued in #30880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid to throw 'not a subtype of type' exception when use custom error widget and sliver.
Related Issues
No issues involved.
Tests
I have not added any tests!
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?