Skip to content

Moar Videos#30452

Merged
goderbauer merged 1 commit intoflutter:masterfrom
goderbauer:moarVideos
Apr 3, 2019
Merged

Moar Videos#30452
goderbauer merged 1 commit intoflutter:masterfrom
goderbauer:moarVideos

Conversation

@goderbauer
Copy link
Member

Description

This adds some videos from the Flutter in Focus playlist to our docs.

Follow-up to #30415, will require #30451.

Related Issues

None

Tests

I added the following tests:

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@goderbauer goderbauer requested a review from sfshaza2 April 3, 2019 17:21
@sfshaza2
Copy link
Contributor

sfshaza2 commented Apr 3, 2019

How are you so fast? LGTM!

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock star!
LGTM! 🤘

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels. labels Apr 3, 2019
@goderbauer
Copy link
Member Author

The lucy build is actually green.

@goderbauer goderbauer merged commit 5493fe4 into flutter:master Apr 3, 2019
@goderbauer goderbauer deleted the moarVideos branch April 3, 2019 19:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants