Skip to content

Fix gallery API doc URL launcher#30460

Merged
HansMuller merged 2 commits intoflutter:masterfrom
HansMuller:gallery_launch_browser
Apr 3, 2019
Merged

Fix gallery API doc URL launcher#30460
HansMuller merged 2 commits intoflutter:masterfrom
HansMuller:gallery_launch_browser

Conversation

@HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Apr 3, 2019

Fixes #30450

xster
xster reviewed Apr 3, 2019
View reviewed changes
Copy link
Member

@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/flutter_gallery/lib/gallery/demo.dart Outdated
Expanded(child: demo.demoWidget),
],
),

Copy link
Member

@xster xster Apr 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintended line?

Copy link
Contributor Author

@HansMuller HansMuller Apr 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks

@HansMuller HansMuller mentioned this pull request Apr 3, 2019
Closed
@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. labels Apr 3, 2019
@HansMuller
Copy link
Contributor Author

HansMuller commented Apr 3, 2019

Build is actually green: #30452 (comment)

@HansMuller HansMuller merged commit 9fe6be8 into flutter:master Apr 3, 2019
@HansMuller HansMuller deleted the gallery_launch_browser branch April 3, 2019 23:57
@shihaohong shihaohong mentioned this pull request May 13, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster xster left review comments

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gallery app bug - "API Documentation" action broken

4 participants

@HansMuller @xster @goderbauer @googlebot