Revert "Error message for setting shaderWarmUp too late (#30145)"#30463
Merged
liyuqian merged 1 commit intoflutter:masterfrom Apr 3, 2019
Merged
Revert "Error message for setting shaderWarmUp too late (#30145)"#30463liyuqian merged 1 commit intoflutter:masterfrom
liyuqian merged 1 commit intoflutter:masterfrom
Conversation
This reverts commit ffbb335. Reason for revert: flutter driver tests may have bugs in getting first frame. Revert this until we figure out what happened.
Contributor
Author
Contributor
Author
|
Internal bug 129875208 has more details of the driver test failure. |
goderbauer
added
framework
Contributor
Author
|
Merge on red flutter-build as @mklim suggested that "Flutter infra" is really green. |
Contributor
Author
|
The Internal bug 129875208 is caused by: In order to pass the "setting shaderWarmUp too late" check, the test has to move the shaderWarmUp to an earlier point, which increases the startup time, which makes the first screenshot black, which breaks the golden test... A proper waiting for the first frame would solve the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ffbb335.
Reason for revert: flutter driver tests may have bugs in getting first frame. Revert this until we figure out what happened.