Skip to content

Check that ErrorWidget.builder is not modified after test#30898

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
dnfield:error_widget_check
Apr 15, 2019
Merged

Check that ErrorWidget.builder is not modified after test#30898
jonahwilliams merged 1 commit intoflutter:masterfrom
dnfield:error_widget_check

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 11, 2019

Description

Adds a check that the ErrorWidget.builder is not permanently modified by a test.

Related Issues

Fixes #30897

Tests

Updated an existing test that did this so it doesn't do it anymore. It didn't cause a problem previously because it was the only test of its type in a file.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@goderbauer goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label Apr 12, 2019
@dnfield dnfield added a: tests "flutter test", flutter_test, or one of our tests waiting for tree to go green labels Apr 12, 2019
@jonahwilliams jonahwilliams merged commit 330dc94 into flutter:master Apr 15, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A test can change ErrorWidget.builder without resetting it.

4 participants