2d transforms UX improvements#30932
Merged
justinmc merged 5 commits intoflutter:masterfrom Apr 15, 2019
Merged
Conversation
goderbauer
added
framework
Piinks
approved these changes
Apr 13, 2019
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
LGTM once the analyzer is happy!
| @override | ||
| Widget build (BuildContext context) { | ||
| if (!_seenInstructionDialog) { | ||
| Future<void>.delayed(Duration(seconds: 1), () { |
Contributor
There was a problem hiding this comment.
Suggested change
| Future<void>.delayed(Duration(seconds: 1), () { | |
| Future<void>.delayed(const Duration(seconds: 1), () { |
Makes analyzer happy. 😊
Contributor
Author
There was a problem hiding this comment.
On it. Thanks for the review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just makes the 2D Transformations demo in the Flutter Gallery a bit more user friendly. I added a title in the app bar and a first-time dialog with a description.