[scenic] Remove dead view_manager ref#31005
Merged
arbreng merged 1 commit intoflutter:masterfrom Apr 16, 2019
arbreng:remove-view-manager
Merged
[scenic] Remove dead view_manager ref#31005arbreng merged 1 commit intoflutter:masterfrom arbreng:remove-view-manager
arbreng merged 1 commit intoflutter:masterfrom
arbreng:remove-view-manager
Conversation
zanderso
reviewed
Apr 16, 2019
Member
zanderso
left a comment
There was a problem hiding this comment.
lgtm
For Flutter PRs the practice is to wait for an lgtm before merging.
Contributor
Author
|
Thanks for the review; I'msorry about that! The change seemed so safe that I figured I could just merge it this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fuchsia doesn't use view_manager anymore, so remove this from the CMX template
Related Issues
N/A
Tests
N/A, no behavior change
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?