Skip to content

Updates template kotlin version to 1.3.30 and AGP to 3.3.2#31029

Closed
josh-burton wants to merge 4 commits intoflutter:masterfrom
josh-burton:kotlin-update
Closed

Updates template kotlin version to 1.3.30 and AGP to 3.3.2#31029
josh-burton wants to merge 4 commits intoflutter:masterfrom
josh-burton:kotlin-update

Conversation

@josh-burton
Copy link
Contributor

@josh-burton josh-burton commented Apr 14, 2019 •
edited
Loading

Description

This PR updates the Kotlin and Android Gradle Plugin, and Gradle version of the project templates and samples to the latest stable version of each.

Related Issues

Tests

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 15, 2019
@josh-burton josh-burton force-pushed the kotlin-update branch 2 times, most recently from 9168135 to 25f05e7 Compare April 19, 2019 22:18
@josh-burton josh-burton mentioned this pull request May 11, 2019
Closed
9 tasks
@googlebot
Copy link

googlebot commented Jun 8, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 8, 2019
@josh-burton josh-burton changed the base branch from dev to master June 8, 2019 02:19
@blasten
Copy link

blasten commented Jul 18, 2019

This is a duplicate of #32550

@blasten
Copy link

blasten commented Aug 1, 2019

@athornz are you still working on this PR or would you be okay if we move the conversation to #32550?

@josh-burton
Copy link
Contributor Author

josh-burton commented Aug 1, 2019

@blasten happy to move the conversation else where.

@josh-burton josh-burton closed this Aug 1, 2019
@josh-burton josh-burton deleted the kotlin-update branch August 1, 2019 18:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josh-burton @googlebot @blasten @goderbauer