Add sorting to flutter version command#31064
Merged
jonahwilliams merged 2 commits intoflutter:masterfrom Apr 16, 2019
rostopira:patch-2
Merged
Add sorting to flutter version command#31064jonahwilliams merged 2 commits intoflutter:masterfrom rostopira:patch-2
jonahwilliams merged 2 commits intoflutter:masterfrom
rostopira:patch-2
Conversation
Contributor
|
This ordering places newer versions last - should it be the other way around? |
Contributor
Author
|
@jonahwilliams I think yes, but current flutter implementation does the opposite |
goderbauer
added
the
tool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31013
Description
This PR adds sorting to
flutter versioncommandThis makes
v1.4.19appear afterv1.4.9and not afterv1.4.1Related Issues
Fixes #31013
Tests
No tests
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?