Clarify various CupertinoTabView docs#31109
Merged
xster merged 2 commits intoflutter:masterfrom Apr 17, 2019
Merged
Conversation
redbrogdon
approved these changes
Apr 16, 2019
| /// Use [CupertinoTabView] as the content of each tab to support tabs with parallel | ||
| /// navigation state and history. | ||
| /// Use [CupertinoTabView] as the root content of each tab to support tabs with | ||
| /// parallel navigation state and history. Since each [CupertinoTabView] nests |
Contributor
There was a problem hiding this comment.
nits:
"root content" => "root widget"
"nests" => "contains"
nix "inner" at the start of line 28.
| /// If a [builder] is specified, then [routes] must not include an entry for `/`, | ||
| /// as [builder] takes its place. | ||
| /// | ||
| /// Updating the [builder]'s existing [WidgetBuilder] instance will not clear |
Contributor
There was a problem hiding this comment.
nits:
Rebuilding a [CupertinoTabView] with a different [builder] will not clear its current navigation stack or update its descendants. Instead, trigger a rebuild from a widget lower in its subtree. This can be done via methods such as:
- Calling [State.setState] on a descendant [StatefulWidget]'s [State] object.
- Modifying an [InheritedWidget] from which a descendant has inherited.
Member
Author
There was a problem hiding this comment.
Done with some tweaks. We're not technically triggering a rebuild from a 'widget' since Widget instances can't 'do' anything.
'from which a descendant has inherited' is technically right but might be a bit vague.
Hixie
added
f: cupertino
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Let me know if this makes it a bit clearer