Skip to content

Add desktop workflows to doctor#31283

Merged
stuartmorgan-g merged 1 commit intomasterfrom
doctor-allow-desktop
Apr 19, 2019
Merged

Add desktop workflows to doctor#31283
stuartmorgan-g merged 1 commit intomasterfrom
doctor-allow-desktop

Conversation

@stuartmorgan-g
Copy link
Contributor

Description

The 'doctor' check to determine if any devices can be listed for the
device should consider desktop workflows as well. This allows commands
like 'run' that do an initial sanity check with the doctor to work when desktop
is enabled.

This has no effect unless the environment variable to enable desktop
device listing is set.

Related Issues

#30707

Tests

I added the following tests: None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

The 'doctor' check to determine if any devices can be listed for the
device should consider desktop workflows as well.

This has no effect unless the environment variable to enable desktop
device listing is set.
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added e: desktop tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 18, 2019
@stuartmorgan-g stuartmorgan-g merged commit d9718aa into master Apr 19, 2019
@stuartmorgan-g stuartmorgan-g deleted the doctor-allow-desktop branch April 19, 2019 03:54
@stuartmorgan-g stuartmorgan-g added the a: desktop Running on desktop label Jul 26, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: desktop Running on desktop tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants