Add InkWell docs on transitions and ink splash clipping#31316
Merged
shihaohong merged 10 commits intoflutter:masterfrom Apr 26, 2019
shihaohong:inkwell-docs
Merged
Add InkWell docs on transitions and ink splash clipping#31316shihaohong merged 10 commits intoflutter:masterfrom shihaohong:inkwell-docs
shihaohong merged 10 commits intoflutter:masterfrom
shihaohong:inkwell-docs
Conversation
shihaohong
added
d: api docs
HansMuller
reviewed
Apr 23, 2019
Contributor
Author
|
Had an offline discussion with @HansMuller, we had misunderstood the actual source of the clipping, so I'll be playing around InkWell and an animated child that changes size before I come up with an updated description of the issue |
HansMuller
approved these changes
Apr 24, 2019
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM with just a little more tweaking.
Incorporated code review feedback to clarify that clipping cannot be avoided with growing animated containers. Further correct grammar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a section to the
InkWelldocumentation highlighting that widget transitions within an InkWell widget may cause clipping or unpleasant rippling effects.Related Issues
Fixes #5211
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?