Clean up flutter_test/test/controller_test.dart#31333
Merged
dkwingsmt merged 2 commits intoflutter:masterfrom May 6, 2019
Merged
Clean up flutter_test/test/controller_test.dart#31333dkwingsmt merged 2 commits intoflutter:masterfrom
dkwingsmt merged 2 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
cc @dkwingsmt |
Contributor
Author
9 tasks
goderbauer
added
a: tests
Contributor
|
I landed #30942 - do you want me to work on the merge conflicts here? |
Instead of using a custom WidgetController, which is very brittle, we just use the usual infrastructure. Also, use structured data instead of an array. This adds offsetMoreOrLessEquals to handle small floating point errors in offsets.
9 tasks
Contributor
Author
|
Merge conflicts are fixed, just needs review. |
Member
|
@Hixie Can you resolve the merge conflict? |
Contributor
Author
|
Feel free to land this if the tree is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using a custom WidgetController, which is very brittle, we just use the usual infrastructure.
Also, use structured data instead of an array.
This adds offsetMoreOrLessEquals to handle small floating point errors in offsets.