Allow all tests to run with --update-goldens.#31554
Closed
sjindel-google wants to merge 1 commit intoflutter:masterfrom
Closed
Allow all tests to run with --update-goldens.#31554sjindel-google wants to merge 1 commit intoflutter:masterfrom
sjindel-google wants to merge 1 commit intoflutter:masterfrom
Conversation
sjindel-google
requested review from
goderbauer and
mkustermann
and removed request for
mkustermann
Contributor
Author
|
Actually we can just implement this in our 3xH patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
benchmark_test.dartwould terminateflutter testif all tests are run with--update-goldens.It is important for the Dart team to be able to run all tests this way to avoid maintaining golden files.