TimePicker moves to minute mode after hour selection#31566
Merged
darrenaustin merged 3 commits intoflutter:masterfrom Apr 25, 2019
darrenaustin:time_picker_switching
Merged
TimePicker moves to minute mode after hour selection#31566darrenaustin merged 3 commits intoflutter:masterfrom darrenaustin:time_picker_switching
darrenaustin merged 3 commits intoflutter:masterfrom
darrenaustin:time_picker_switching
Conversation
This is a merging of two pull requests: - Code changes from @sdolski - Tests from @lucaslcode
… for the onHourSelected callback.
HansMuller
approved these changes
Apr 24, 2019
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
LGTM with some trivial changes
- Added more asserts for the _Dial constructor - Null guarded the onHourSelected callback - Extracted some variables in the test to make it more explicit what it was doing.
This was referenced Apr 25, 2019
15 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a feature of the native Android Time Picker to our Material Time Picker. When the user selects an hour, it automatically switches to minute mode.
This is a merging of two pull requests:
Thanks to both of you for your contributions!
Related Issues
Fixes #17276, #29600
Tests
The following tests were added from @lucaslcode:
'tap-select switches from hour to minute'
'drag-select switches from hour to minute'
to time_picker_test.dart.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?