Roll engine to 3e47b4bb39bb4993f03a278ea7b1c11ee6459b06#31569
Merged
dnfield merged 9 commits intoflutter:masterfrom Apr 25, 2019
Merged
Roll engine to 3e47b4bb39bb4993f03a278ea7b1c11ee6459b06#31569dnfield merged 9 commits intoflutter:masterfrom
dnfield merged 9 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
Once the custom embedders have caught up, I will re-enable the lint and fix the callsites. |
liyuqian
approved these changes
Apr 24, 2019
Contributor
|
@dnfield there's a golden test failure |
krisgiesing
reviewed
Apr 24, 2019
| final double dx = math.cos(angle) * 5.0; | ||
| final double dy = math.sin(angle) * 5.0; | ||
| // These values should be truncated so that double precision rounding | ||
| // issues won't impact the heights/widths and throw off the |
Contributor
There was a problem hiding this comment.
Missing end of sentence?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27320
Flutter engine c63d1cf..3e47b4b to:
flutter/engine@3e47b4bb3 Reland const Rect/RRect (flutter/engine#8695)
flutter/engine@098ada539 Convert animated unpremul images to premul during decode (flutter/engine#8698)
This roll temporarily disables the prefer const constructor lint. We have over 800 callsites that need to be updated, but want to give custom embedders a cushion here to get a chance to have dart:ui rolled to them.
There's a chance that this could break tests in google3 because of precision changes. The semantics traversal test is an example of this. A previous PR added a
rectMoreOrLessEqualsto help with that.