Make FlutterPlatform public so we can start testing/refactoring it#31616
Merged
jonahwilliams merged 1 commit intoflutter:masterfrom Apr 25, 2019
Merged
Conversation
Contributor
Author
zanderso
approved these changes
Apr 25, 2019
| class _FlutterPlatform extends PlatformPlugin { | ||
| _FlutterPlatform({ | ||
| /// The flutter test platform used to integrate with package:test. | ||
| class FlutterPlatform extends PlatformPlugin { |
Member
There was a problem hiding this comment.
Consider adding docs for the public fields/methods.
Contributor
Author
There was a problem hiding this comment.
I'd like to significantly refactor this configuration so these will likely move around a bit over the next few weeks. I will ensure each field is documented once moved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes FlutterPlatform public (though really still an implementation detail) so we can test it. Adds two test cases to verify behavior wrt explicit observatory ports and precompiled entry-points.