Refactor the test compiler into a separate library#31642
Merged
jonahwilliams merged 2 commits intoflutter:masterfrom Apr 26, 2019
Merged
Refactor the test compiler into a separate library#31642jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams merged 2 commits intoflutter:masterfrom
Conversation
gspencergoog
approved these changes
Apr 26, 2019
| /// This class is a wrapper around compiler that allows multiple isolates to | ||
| /// enqueue compilation requests, but ensures only one compilation at a time. | ||
| class TestCompiler { | ||
| TestCompiler( |
Contributor
There was a problem hiding this comment.
Maybe a doc comment about what the parameters are for and their contract?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the test compiler into a separate library, and refactors it to use fewer closures. Adds a simple test that given a compilation request, it produces the expected dill file.
Also some assorted formatting fixes in the test file folder.