Cupertino localization step 12: push translation for all supported languages#31644
Cupertino localization step 12: push translation for all supported languages#31644xster merged 6 commits intoflutter:masterfrom
Conversation
|
Pending another xml push into TC before pulling again |
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "todayLabel": "a temporary hack", | |||
There was a problem hiding this comment.
the latin script in this file is a placeholder while the remaining 3 strings are being translated
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "todayLabel": "a temporary hack", | |||
There was a problem hiding this comment.
the latin script in this file is a placeholder while the remaining 3 strings are being translated
lgfranco
left a comment
There was a problem hiding this comment.
I made the changes to reflect the iOS in pt and pt_PT
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "todayLabel": "Hoje", | |||
| "datePickerHourSemanticsLabelOne": "$hour em ponto", | |||
There was a problem hiding this comment.
"$hour hora"
| "datePickerHourSemanticsLabelOne": "$hour em ponto", | |
| "datePickerHourSemanticsLabelOne": "$hour hora", |
There was a problem hiding this comment.
Thanks for diff'ing and reviewing. We'll backport these into the translation console
There was a problem hiding this comment.
I assume these are both for brazilian and portugal portuguese?
There was a problem hiding this comment.
Yes, the use of "em ponto" is not for this situation.
The use wold be for something like 8 o'clock (8 "horas em ponto").
| "timerPickerHourLabelOther": "horas", | ||
| "timerPickerMinuteLabelOne": "min", | ||
| "timerPickerMinuteLabelOther": "min", | ||
| "timerPickerSecondLabelOne": "s", |
There was a problem hiding this comment.
The correct would be s but the iOS writes "seg" in this locale.
| "timerPickerSecondLabelOne": "s", | |
| "timerPickerSecondLabelOne": "seg", |
| "timerPickerHourLabelOther": "horas", | ||
| "timerPickerMinuteLabelOne": "min", | ||
| "timerPickerMinuteLabelOther": "min", | ||
| "timerPickerSecondLabelOne": "seg", |
There was a problem hiding this comment.
| "timerPickerSecondLabelOne": "seg", | |
| "timerPickerSecondLabelOne": "s", |
There was a problem hiding this comment.
Seems like you're suggesting opposite things between here and the same label in the previous file.
There was a problem hiding this comment.
Yes, for some reason the iOS abbreviates seconds in different ways in pt and pt_PT.
I changed my iPhone to pt_PT, accessed the Timer (in the clock App), and used the strings I found there.
| "timerPickerMinuteLabelOne": "min", | ||
| "timerPickerMinuteLabelOther": "min", | ||
| "timerPickerSecondLabelOne": "seg", | ||
| "timerPickerSecondLabelOther": "seg", |
There was a problem hiding this comment.
| "timerPickerSecondLabelOther": "seg", | |
| "timerPickerSecondLabelOther": "s", |
HansMuller
left a comment
There was a problem hiding this comment.
RSLGTM
Translation feedback will have to be funneled through the Google TC
|
pt_PT examples pt examples |
|
I'm merging this one in for now. The feedback received will cycle through via another update once the TC translations are internalized. |
Fixes #13452
When making change suggestions, please double check in iOS so I can justify it with our translators.