Reland "Fix text field selection toolbar under Opacity (#31097)"#31802
Merged
liyuqian merged 3 commits intoflutter:masterfrom Apr 30, 2019
Merged
Reland "Fix text field selection toolbar under Opacity (#31097)"#31802liyuqian merged 3 commits intoflutter:masterfrom
liyuqian merged 3 commits intoflutter:masterfrom
Conversation
liyuqian
added a commit
to flutter/goldens
that referenced
this pull request
Apr 29, 2019
goderbauer
added
the
framework
Contributor
|
do we understand how this failed before? |
Contributor
|
(was it just a new test that was added between when the PR was written and tested, and when it landed?) |
Contributor
|
We forgot to roll the golden files |
Contributor
Author
|
@Hixie : the PR was created about 3 days ago and the the golden file was generated at that time based on flutter master 3 days ago; in the last 2 days, someone landed changes that affects the golden file, but I didn't rebase the PR to the newest master before merging. Our presubmit only checks against my old base, not the master, while the post-submit always checks against the newest master, so the post-submit failed while the pre-submit passed. This race condition seems to be possible in any CI system that I've worked with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the golden file