Skip to content

remove assert#31815

Merged
dnfield merged 1 commit intoflutter:masterfrom
dnfield:remove_assert
Apr 30, 2019
Merged

remove assert#31815
dnfield merged 1 commit intoflutter:masterfrom
dnfield:remove_assert

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 29, 2019

Description

This assert is hitting and causing a crash we don't have an immediate resolution for on Flutter Driver.

Until we figure out and fix #31813, we should disable this check.

Related Issues

#31813

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dnfield dnfield merged commit eac2104 into flutter:master Apr 30, 2019
@dnfield dnfield deleted the remove_assert branch April 30, 2019 00:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No such method: streamNotify

4 participants