remove unnecessary artificial delay in catalog example#31822
Merged
Piinks merged 2 commits intoflutter:masterfrom May 3, 2019
Merged
remove unnecessary artificial delay in catalog example#31822Piinks merged 2 commits intoflutter:masterfrom
Piinks merged 2 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
@Hixie Would you review this ? |
Contributor
|
Do we have any code anywhere that tests that this code works when generated? |
Contributor
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I read catalog example, I found unnecessary artificial delay Now.
It is because #12896 Merged. So, I remove the line.
Related Issues
delay taking screenshot to allow GPU thread to render the frameTests
no addition.
test task code is https://github.com/flutter/flutter/blob/master/dev/devicelab/lib/tasks/sample_catalog_generator.dart#L30-L37
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?