Merged
Conversation
Contributor
Author
|
@Hixie Would you review this ? |
goderbauer
added
the
framework
sensuikan1973
force-pushed
the
fix_driver_waitFor_timeout
branch
from
eb84d1c to
df82b89
Compare
sensuikan1973
changed the title
Contributor
|
We should add a test for this. Otherwise someone might change this back and not realise it was intentional. |
Contributor
Author
|
@Hixie
|
Piinks
added
the
t: flutter driver
dnfield
reviewed
May 3, 2019
|
|
||
| import 'common.dart'; | ||
|
|
||
| /// Default timeout value. |
Contributor
There was a problem hiding this comment.
nit: document that this should correspond to _kUnusuallyLongTimeout in driver.dart.
Perhaps it would make sense to just let that constant become public with an @visibleForTesting on it. It doesn't seem like it should hurt anything to leak that as public to me.
Contributor
Author
There was a problem hiding this comment.
Thank you for review.
I will fix.
Contributor
Author
Contributor
|
Deploy gallery failure is safe to ignore here, thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FlutterDriver method's timeout is unexpected, I think.
example : waitFor, waitForAbsent, tap and so on.
If I pass timeout argument less than 5 seconds (ex: 3 seconds), I expect waitFor method times out in 3 seconds. But, waitFor mathod times out in 5 seconds.
→ I changed the behavior. So, now, the behavior matches document.
Related Issues
Tests
I added the test to ensure that custom timeout works.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?