Skip to content

Add documentation to Navigator#31851

Merged
tvolkert merged 2 commits intoflutter:masterfrom
tvolkert:navdocs
May 2, 2019
Merged

Add documentation to Navigator#31851
tvolkert merged 2 commits intoflutter:masterfrom
tvolkert:navdocs

Conversation

@tvolkert
Copy link
Contributor

No description provided.

@tvolkert tvolkert added the framework flutter/packages/flutter repository. See also f: labels. label Apr 30, 2019
/// the use of routes and the Navigator is appropriate. On certain platforms,
/// such as Android, the system UI will provide a back button (outside the
/// bounds of your application) that will allow the user to navigate back
/// to earlier routes in your application's stack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leaves me with the question what I as a dev should do on non-android platforms.

Maybe a link to the appbar would be helpful that for most use cases shows a back button, if the navigator stack has content? See https://master-api.flutter.dev/flutter/material/AppBar/leading.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - done.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert tvolkert merged commit f48cc46 into flutter:master May 2, 2019
@tvolkert tvolkert deleted the navdocs branch May 2, 2019 15:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants