Simplify drawer scrimColor defaults, update tests#31947
Merged
HansMuller merged 3 commits intoflutter:masterfrom May 2, 2019
Merged
Simplify drawer scrimColor defaults, update tests#31947HansMuller merged 3 commits intoflutter:masterfrom
HansMuller merged 3 commits intoflutter:masterfrom
Conversation
rami-a
approved these changes
May 2, 2019
Contributor
rami-a
left a comment
rami-a
left a comment
There was a problem hiding this comment.
LGTM with one small suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a small bug introduced by #31025: changing the DrawerController's scrimColor didn't update the DrawerControllerState's cached color Tween.
Simplified the defaulting a little: DrawerController provides the default scrimColor; all scrim color parameters default to null.