Merged
Conversation
Closed
Hixie
reviewed
May 2, 2019
|
|
||
| export 'package:flutter/services.dart' show TextRange, TextSelection; | ||
|
|
||
| /// The different ways of considering the width of a Text widget. |
Contributor
There was a problem hiding this comment.
nit: use square brackets around any identifier (other than arguments that don't correspond to properties; those get backticks)
nit: this is in the painting layer, which doesn't have to be used with widgets. This can certainly talk about widgets, but it should also talk about TextPainter itself, which is what this layer knows about.
Hixie
reviewed
May 2, 2019
| /// [Text.maxLines]. | ||
| final int maxLines; | ||
|
|
||
| /// The strategy to use when calculating the width of the Text. See |
Contributor
There was a problem hiding this comment.
nit: same thing as above here, but additionally, put only one sentence in the first paragraph.
see https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#dartdoc-specific-requirements
Contributor
Author
|
@Hixie Fixed! Thanks. |
dnfield
added
framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #30988 after it was reverted (due to build bug where my engine change isn't picked up).
Closes #26585