Remove deprecated decodedCacheRatioCap#32041
Merged
mklim merged 1 commit intoflutter:masterfrom May 6, 2019
mklim:remove_cache_cap
Merged
Remove deprecated decodedCacheRatioCap#32041mklim merged 1 commit intoflutter:masterfrom mklim:remove_cache_cap
mklim merged 1 commit intoflutter:masterfrom
mklim:remove_cache_cap
Conversation
liyuqian
approved these changes
May 3, 2019
Contributor
liyuqian
left a comment
liyuqian
left a comment
There was a problem hiding this comment.
LGTM. My only concern is that the announcement is sent today so we probably need to give developers more time to digest this breaking change before we merge it.
Contributor
Author
|
Sounds good. For what it's worth the field has also been marked as |
goderbauer
added
the
framework
Member
|
@mklim thoughts on the timing of landing this? Given that it's been deprecated for a while now, is there any chance that we won't land this? If not, then I think it's reasonable to land now, as it'll take a bit to migrate up to beta channel in any case. |
Contributor
Author
|
@cbracken I think that's reasonable. I'll land once the build is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecated decodedCacheRatioCap.
Related Issues
#26081
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?