Test Material buttons against a11y contrast guidelines#32050
Merged
HansMuller merged 3 commits intoflutter:masterfrom May 3, 2019
Merged
Test Material buttons against a11y contrast guidelines#32050HansMuller merged 3 commits intoflutter:masterfrom
HansMuller merged 3 commits intoflutter:masterfrom
Conversation
johnsonmh
approved these changes
May 3, 2019
| ), | ||
| ); | ||
|
|
||
| // Default, not disabled |
Contributor
There was a problem hiding this comment.
Suggested change
| // Default, not disabled | |
| // Default, not disabled. |
| // Default, not disabled | ||
| await expectLater(tester, meetsGuideline(textContrastGuideline)); | ||
|
|
||
| // Highlighted (pressed) |
Contributor
There was a problem hiding this comment.
Suggested change
| // Highlighted (pressed) | |
| // Highlighted (pressed). |
| // Highlighted (pressed) | ||
| final Offset center = tester.getCenter(find.byType(FlatButton)); | ||
| await tester.startGesture(center); | ||
| await tester.pump(const Duration(milliseconds: 200)); // wait for splash to be well under way |
Contributor
There was a problem hiding this comment.
Suggested change
| await tester.pump(const Duration(milliseconds: 200)); // wait for splash to be well under way | |
| await tester.pump(const Duration(milliseconds: 200)); // Wait for splash to be well under way. |
| }); | ||
| } | ||
|
|
||
| PhysicalModelLayer _findPhysicalLayer(Element element) { |
Contributor
There was a problem hiding this comment.
these were just renamed and moved right? No functionality change?
Contributor
Author
There was a problem hiding this comment.
That's right. They were jammed at the top of main() with the wrong indent. We usually stick helpers like this at the end of test files and often (not always) use file-private names. That's all I did here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a11y constrast guideline unit tests for the default configurations of RaisedButton, OutlineButton, FlatButton, and MaterialButton.
Made a few additional gratuitous cosmetic changes to the button tests.