Skip to content

[flutter_tool] In 'attach' use platform dill etc from the Fuchsia SDK#32071

Merged
zanderso merged 1 commit intoflutter:masterfrom
zanderso:fuchsia-artifact-overrides
May 6, 2019
Merged

[flutter_tool] In 'attach' use platform dill etc from the Fuchsia SDK#32071
zanderso merged 1 commit intoflutter:masterfrom
zanderso:fuchsia-artifact-overrides

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented May 3, 2019

Description

This PR:

  1. Provides a facility for devices to override artifacts. (So far just those from OverrideArtifacts).
  2. Uses that in the attach command so that the Fuchsia device can provide the platform dill, etc. from the Fuchsia SDK.

Related Issues

Tests

I added the following tests:

Tests of Fuchsia device artifact overriding in fuchsia_device_test.dart.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label May 6, 2019
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit 61236c8 into flutter:master May 6, 2019
@zanderso zanderso deleted the fuchsia-artifact-overrides branch May 6, 2019 16:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants